Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.28] Fix new coverity issues #9729

Conversation

paul-elliott-arm
Copy link
Member

@paul-elliott-arm paul-elliott-arm commented Oct 25, 2024

Description

Backport of the relevant parts of #9721 (Some tests did not exist / bignum codepath tests did not exist)

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog provided | not required because: No serious issues fixed
  • development PR provided Fix new coverity issues #9721 ~~| not required because: ~~
  • framework PR provided Mbed-TLS/mbedtls-framework# | not required : No framework component
  • 3.6 PR provided [Backport 3.6] Fix new coverity issues #9723 ~~| not required because: ~~
  • 2.28 PR provided # | not required because: This is the 2.28 backport
  • tests provided | not required because: Existing tests suffice

Variables that are in any way destructed on exit should be initialised
prior to any tests that might jump to exit, to save potential
uninitialised memory accesses.

Signed-off-by: Paul Elliott <[email protected]>
Signed-off-by: Paul Elliott <[email protected]>
@paul-elliott-arm paul-elliott-arm added bug needs-ci Needs to pass CI tests component-test Test framework and CI scripts size-xs Estimated task size: extra small (a few hours at most) labels Oct 25, 2024
@paul-elliott-arm paul-elliott-arm self-assigned this Oct 25, 2024
@paul-elliott-arm paul-elliott-arm mentioned this pull request Oct 25, 2024
5 tasks
Signed-off-by: Paul Elliott <[email protected]>
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon and removed needs-ci Needs to pass CI tests labels Oct 25, 2024
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@davidhorstmann-arm davidhorstmann-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Oct 25, 2024
@davidhorstmann-arm davidhorstmann-arm added this pull request to the merge queue Oct 25, 2024
@davidhorstmann-arm davidhorstmann-arm removed this pull request from the merge queue due to a manual request Oct 25, 2024
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Oct 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2024
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Oct 29, 2024
Merged via the queue into Mbed-TLS:mbedtls-2.28 with commit 89a87b5 Oct 29, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports bug component-test Test framework and CI scripts priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Development

Successfully merging this pull request may close these issues.

3 participants