-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.28] Fix new coverity issues #9729
Merged
gilles-peskine-arm
merged 4 commits into
Mbed-TLS:mbedtls-2.28
from
paul-elliott-arm:fix_new_coverity_issues_2.28
Oct 29, 2024
Merged
[Backport 2.28] Fix new coverity issues #9729
gilles-peskine-arm
merged 4 commits into
Mbed-TLS:mbedtls-2.28
from
paul-elliott-arm:fix_new_coverity_issues_2.28
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variables that are in any way destructed on exit should be initialised prior to any tests that might jump to exit, to save potential uninitialised memory accesses. Signed-off-by: Paul Elliott <[email protected]>
Signed-off-by: Paul Elliott <[email protected]>
Signed-off-by: Paul Elliott <[email protected]>
paul-elliott-arm
added
bug
needs-ci
Needs to pass CI tests
component-test
Test framework and CI scripts
size-xs
Estimated task size: extra small (a few hours at most)
labels
Oct 25, 2024
5 tasks
Signed-off-by: Paul Elliott <[email protected]>
5 tasks
gilles-peskine-arm
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gilles-peskine-arm
added
needs-review
Every commit must be reviewed by at least two team members,
needs-reviewer
This PR needs someone to pick it up for review
priority-high
High priority - will be reviewed soon
and removed
needs-ci
Needs to pass CI tests
labels
Oct 25, 2024
davidhorstmann-arm
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
davidhorstmann-arm
added
approved
Design and code approved - may be waiting for CI or backports
and removed
needs-review
Every commit must be reviewed by at least two team members,
needs-reviewer
This PR needs someone to pick it up for review
labels
Oct 25, 2024
davidhorstmann-arm
removed this pull request from the merge queue due to a manual request
Oct 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 28, 2024
Merged
via the queue into
Mbed-TLS:mbedtls-2.28
with commit Oct 29, 2024
89a87b5
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Design and code approved - may be waiting for CI or backports
bug
component-test
Test framework and CI scripts
priority-high
High priority - will be reviewed soon
size-xs
Estimated task size: extra small (a few hours at most)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of the relevant parts of #9721 (Some tests did not exist / bignum codepath tests did not exist)
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.
provided |not required because: No serious issues fixedprovided Mbed-TLS/mbedtls-framework#| not required : No framework componentprovided # |not required because: This is the 2.28 backportprovided |not required because: Existing tests suffice