Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psa_cipher_decrypt CCM*: fix rejection of messages shorter than 3 bytes #9315

Merged
merged 1 commit into from
Jul 4, 2024
Merged

psa_cipher_decrypt CCM*: fix rejection of messages shorter than 3 bytes #9315

merged 1 commit into from
Jul 4, 2024

Conversation

gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented Jun 26, 2024 •
edited
Loading

Found by Cryptofuzz. Fixes #9314.

Specification links:

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, component-crypto Crypto primitives and low-level interfaces needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Jun 26, 2024
@sezrab sezrab assigned sezrab and unassigned sezrab Jun 26, 2024
@sezrab sezrab self-requested a review June 26, 2024 13:19
sezrab
sezrab approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@sezrab sezrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yanesca
yanesca approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Jul 3, 2024
Merged
4 tasks
@gilles-peskine-arm gilles-peskine-arm added needs-backports Backports are missing or are pending review and approval. approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jul 3, 2024
sezrab

This comment was marked as duplicate.

Sign in to view

@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Jul 4, 2024
Merged via the queue into Mbed-TLS:development with commit c971d80 Jul 4, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sezrab sezrab sezrab approved these changes

@yanesca yanesca yanesca approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces needs-backports Backports are missing or are pending review and approval. priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Projects
Roadmap Board for Mbed TLS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

psa_cipher_decrypt with CCM* rejects very short messages
3 participants
@gilles-peskine-arm @yanesca @sezrab