Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 2.28: Set psk to NULL in ssl_psk_remove #9246

Conversation

lhuang04
Copy link
Contributor

@lhuang04 lhuang04 commented Jun 11, 2024

Summary:
Back port PR 9241 to 2.28 branch

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Description

Please write a few sentences describing the overall goals of the pull request's commits.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog provided, or not required
  • 3.6 backport done, or not required
  • 2.28 backport done, or not required
  • tests provided, or not required

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@lhuang04 lhuang04 mentioned this pull request Jun 11, 2024
4 tasks
Summary:
Back port [PR 9241](Mbed-TLS#9241) to
2.28 branch

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Signed-off-by: lhuang04 <[email protected]>
@lhuang04 lhuang04 force-pushed the mbedtls_2_28_psk_null_back_port branch from 841c2b1 to 0a2dd6d Compare June 11, 2024 20:03
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports component-tls labels Jun 12, 2024
@tom-cosgrove-arm tom-cosgrove-arm added this pull request to the merge queue Jun 12, 2024
@tom-cosgrove-arm tom-cosgrove-arm changed the title Set psk to NULL in ssl_psk_remove-backport to 2.28 Backport 2.28: Set psk to NULL in ssl_psk_remove Jun 12, 2024
Merged via the queue into Mbed-TLS:mbedtls-2.28 with commit 152983b Jun 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports component-tls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants