Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Reduce many unnecessary static memory consumption #8798

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Backport 2.28: Reduce many unnecessary static memory consumption #8798

merged 1 commit into from
Feb 8, 2024

Conversation

ivq
Copy link
Contributor

@ivq ivq commented Feb 7, 2024 •
edited
Loading

Description

Backport of #8665

PR checklist

  • changelog Not needed - No user facing changes
  • backport NA - This is a backport
  • tests Not needed - No functional changes

@ivq
Reduce many unnecessary static memory consumption
b6d5793 
.data section of ssl_client1 becomes 128 bytes smaller on AMD64.

Signed-off-by: Chien Wong <[email protected]>
@tom-cosgrove-arm tom-cosgrove-arm added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) labels Feb 7, 2024
@gilles-peskine-arm gilles-peskine-arm self-requested a review February 7, 2024 15:11
gilles-peskine-arm
gilles-peskine-arm approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to backport. This may increase the flash size by a few bytes, but it also saves a few bytes of RAM, and it's less than the size cost of many a bug fix anyway.

@tom-cosgrove-arm tom-cosgrove-arm mentioned this pull request Feb 7, 2024
Merged
3 tasks
@tom-cosgrove-arm tom-cosgrove-arm added enhancement priority-medium Medium priority - this can be reviewed as time permits labels Feb 7, 2024
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Feb 7, 2024
@tom-cosgrove-arm tom-cosgrove-arm added this pull request to the merge queue Feb 7, 2024
Merged via the queue into Mbed-TLS:mbedtls-2.28 with commit ede909f Feb 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports enhancement needs-ci Needs to pass CI tests priority-medium Medium priority - this can be reviewed as time permits size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivq @gilles-peskine-arm @tom-cosgrove-arm