Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport CI perf: Use clang by default in all.sh #8670

Merged
merged 11 commits into from
Jan 4, 2024
Merged

Backport CI perf: Use clang by default in all.sh #8670

merged 11 commits into from
Jan 4, 2024

Conversation

daverodgman
Copy link
Contributor

@daverodgman daverodgman commented Jan 4, 2024 •
edited by minosgalanakis
Loading

Description

Backport of #8642

This was constructed mostly by cherry-picking the individual commits which were applicable. A few were messy and had to be reconstructed by hand, but the changes are very simple so the differences from the main PR are straightforward / obvious.

@daverodgman
Use clang by default
62be456 
Signed-off-by: Dave Rodgman <[email protected]>
@daverodgman
Ensure clang is present
e0a2f6d 
Signed-off-by: Dave Rodgman <[email protected]>
@daverodgman
Ensure test_psa_compliance uses gcc
b0660c2 
Signed-off-by: Dave Rodgman <[email protected]>
@daverodgman
Use gcc in test_psa_compliance
5b00fb1 
Signed-off-by: Dave Rodgman <[email protected]>
@daverodgman
Enable -O2 in depends.py
b046b9a 
Signed-off-by: Dave Rodgman <[email protected]>
@daverodgman
Don't specify gcc unless the test requires it
374b188 
Signed-off-by: Dave Rodgman <[email protected]>
@daverodgman
Add -O2 to some CFLAGS which were not setting it
ce04f24 
Signed-off-by: Dave Rodgman <[email protected]>
@daverodgman
Use gcc in test_full_deprecated_warning
9d2c67f 
Signed-off-by: Dave Rodgman <[email protected]>
@daverodgman
Don't use full path for setting CC
e42c235 
Signed-off-by: Dave Rodgman <[email protected]>
@daverodgman daverodgman mentioned this pull request Jan 4, 2024
Merged
3 tasks
@daverodgman daverodgman added enhancement needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests component-test Test framework and CI scripts priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Jan 4, 2024
mpg
mpg previously approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

tom-cosgrove-arm
tom-cosgrove-arm previously approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jan 4, 2024
@daverodgman daverodgman dismissed stale reviews from tom-cosgrove-arm and mpg via 0fd07d5 January 4, 2024 11:38
@daverodgman daverodgman added needs-review Every commit must be reviewed by at least two team members, and removed approved Design and code approved - may be waiting for CI or backports labels Jan 4, 2024
mpg
mpg approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jan 4, 2024
@daverodgman daverodgman added this pull request to the merge queue Jan 4, 2024
@daverodgman daverodgman removed the needs-ci Needs to pass CI tests label Jan 4, 2024
Merged via the queue into Mbed-TLS:mbedtls-2.28 with commit ffb18d2 Jan 4, 2024
6 checks passed
@ronald-cron-arm ronald-cron-arm mentioned this pull request Mar 4, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@mpg mpg mpg approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-test Test framework and CI scripts enhancement priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daverodgman @mpg @tom-cosgrove-arm