Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog entry for 7298 #8278

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Changelog entry for 7298 #8278

merged 1 commit into from
Sep 29, 2023

Conversation

gilles-peskine-arm
Copy link
Contributor

#7298 wasn't just cleanup, it fixed a bug, so it needs a changelog entry.

And maybe a backport?

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog provided now
  • backport the bug isn't fixed in 2.28
  • tests N/A

@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-very-high Highest priority - prioritise this over other review work labels Sep 29, 2023
@gilles-peskine-arm
Changelog entry for Mbed-TLS#7298
d39edea 
Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Sep 29, 2023
Merged
3 tasks
@daverodgman daverodgman added single-reviewer This PR qualifies for having only one reviewer approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Sep 29, 2023
minosgalanakis
minosgalanakis approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daverodgman daverodgman added this pull request to the merge queue Sep 29, 2023
Merged via the queue into Mbed-TLS:development with commit 0673ed2 Sep 29, 2023
1 check passed
@minosgalanakis minosgalanakis mentioned this pull request Apr 11, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minosgalanakis minosgalanakis minosgalanakis approved these changes

@daverodgman daverodgman daverodgman approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports priority-very-high Highest priority - prioritise this over other review work single-reviewer This PR qualifies for having only one reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilles-peskine-arm @daverodgman @minosgalanakis