Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Add comment about HKDF in config_psa.h #8172

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Backport 2.28: Add comment about HKDF in config_psa.h #8172

merged 1 commit into from
Sep 13, 2023

Conversation

ronald-cron-arm
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm commented Sep 7, 2023 •
edited by minosgalanakis
Loading

Backport of #8171

  • changelog, not required
  • backport, This is the backport
  • tests , not required

@ronald-cron-arm ronald-cron-arm mentioned this pull request Sep 7, 2023
Merged
3 tasks
@ronald-cron-arm ronald-cron-arm added component-psa PSA keystore/dispatch layer (storage, drivers, …) enhancement needs-ci Needs to pass CI tests labels Sep 7, 2023
gilles-peskine-arm
gilles-peskine-arm approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (nothing else in #8171 needs backporting)

@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, approved Design and code approved - may be waiting for CI or backports single-reviewer This PR qualifies for having only one reviewer and removed needs-review Every commit must be reviewed by at least two team members, labels Sep 7, 2023
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronald-cron-arm
Copy link
Contributor Author

I've just changed the commit message to re-trigger the CI as the merge seemed not possible because the DCO check did not complete.

@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Sep 13, 2023
Merged via the queue into Mbed-TLS:mbedtls-2.28 with commit 3d9978e Sep 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-psa PSA keystore/dispatch layer (storage, drivers, …) enhancement needs-ci Needs to pass CI tests single-reviewer This PR qualifies for having only one reviewer
Projects
Roadmap Board for Mbed TLS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronald-cron-arm @gilles-peskine-arm @tom-cosgrove-arm