Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc improvements #7905

Merged
merged 2 commits into from
Nov 23, 2023
Merged

misc improvements #7905

merged 2 commits into from
Nov 23, 2023

Conversation

lpy4105
Copy link
Contributor

@lpy4105 lpy4105 commented Jul 11, 2023 •
edited by daverodgman
Loading

Description

This PR is aimed to collect some improvements or comments of merged PR that were not worth iterating the original ones. Until it contains sufficient contents, this PR is not worth to be reviewed.

Content list

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog not needed
  • backport aesni.h has a backport; the test change does not - not worth backporting
  • tests not needed

@lpy4105 lpy4105 added enhancement size-s Estimated task size: small (~2d) priority-medium Medium priority - this can be reviewed as time permits labels Jul 11, 2023
@lpy4105 lpy4105 force-pushed the issue/misc-improvement branch from 9de2af8 to 6f0259e Compare September 21, 2023 02:35
@lpy4105 lpy4105 added size-xs Estimated task size: extra small (a few hours at most) and removed size-s Estimated task size: small (~2d) labels Sep 21, 2023
@yanrayw
Copy link

yanrayw commented Sep 21, 2023

This is still a draft PR. Any further plans? Ready for review?

@lpy4105
Copy link
Contributor Author

lpy4105 commented Sep 21, 2023

This is still a draft PR. Any further plans? Ready for review?

This is a collection of minor changes those do not worth a single PR. I will mark it ready for review as long as it is large enough.

@daverodgman
Copy link
Contributor

@lpy4105 I think better to merge this, there's no point waiting to add more things.

@lpy4105 lpy4105 marked this pull request as ready for review November 23, 2023 15:34
@lpy4105 lpy4105 added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Nov 23, 2023
@lpy4105
Copy link
Contributor Author

lpy4105 commented Nov 23, 2023

I think better to merge this, there's no point waiting to add more things.

Sure, I've marked it as ready for review.

@daverodgman daverodgman removed the needs-reviewer This PR needs someone to pick it up for review label Nov 23, 2023
minosgalanakis
minosgalanakis approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you please update the check-mark flags?

@daverodgman daverodgman added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Nov 23, 2023
@daverodgman daverodgman added this pull request to the merge queue Nov 23, 2023
Merged via the queue into Mbed-TLS:development with commit c44042d Nov 23, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minosgalanakis minosgalanakis minosgalanakis approved these changes

@daverodgman daverodgman daverodgman approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports enhancement priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpy4105 @yanrayw @daverodgman @minosgalanakis