Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Don't touch the style of generated files #6821

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Backport 2.28: Don't touch the style of generated files #6821

merged 1 commit into from
Dec 19, 2022

Conversation

gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented Dec 19, 2022 •
edited by davidhorstmann-arm
Loading

Gatekeeper checklist

@gilles-peskine-arm
Don't touch the style of generated files
4ca54d4 
Ideally the result of the generator would conform to the code style, but
this would be difficult, especially with respect to the placement of line
breaks in long logical lines. So, to avoid surprises when checking the style
of generated files (which happens in releases and in long-time support
branches), systematically skip generated files.

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm added bug needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) component-test Test framework and CI scripts priority-high High priority - will be reviewed soon labels Dec 19, 2022
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Dec 19, 2022
Merged
3 tasks
mpg
mpg approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - trivial backport of just the first commit, as the second is not relevant for 2.28.

@mpg mpg removed the needs-ci Needs to pass CI tests label Dec 19, 2022
wernerlewis
wernerlewis approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@wernerlewis wernerlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, trivial backport of relevant commit

@wernerlewis wernerlewis added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Dec 19, 2022
@mpg mpg merged commit 71e934f into Mbed-TLS:mbedtls-2.28 Dec 19, 2022
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Feb 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wernerlewis wernerlewis wernerlewis approved these changes

@mpg mpg mpg approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-test Test framework and CI scripts priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilles-peskine-arm @mpg @wernerlewis