Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of ASSERT_ALLOC() #6419

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Fix usage of ASSERT_ALLOC() #6419

merged 1 commit into from
Oct 17, 2022

Conversation

mpg
Copy link
Contributor

@mpg mpg commented Oct 14, 2022 •
edited by daverodgman
Loading

The second argument is the number of elements of the type the first argument is pointing to, so we shouldn't be using sizeof there.

This was resulting in overly large allocations.

@mpg
Fix usage of ASSERT_ALLOC()
47b8de8 
The second argument is the number of elements of the type the first
argument is pointing to, so we shouldn't be using sizeof there.

This was resulting in overly large allocations.

Signed-off-by: Manuel Pégourié-Gonnard <[email protected]>
@mpg mpg added bug needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) labels Oct 14, 2022
@mpg mpg self-assigned this Oct 14, 2022
@mpg mpg added the needs-backports Backports are missing or are pending review and approval. label Oct 14, 2022
@mpg mpg mentioned this pull request Oct 14, 2022
Merged
paul-elliott-arm
paul-elliott-arm approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@paul-elliott-arm paul-elliott-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paul-elliott-arm paul-elliott-arm removed the needs-reviewer This PR needs someone to pick it up for review label Oct 14, 2022
tom-daubney-arm
tom-daubney-arm approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-daubney-arm tom-daubney-arm removed the needs-review Every commit must be reviewed by at least two team members, label Oct 14, 2022
This was referenced Oct 14, 2022
Open
Open
@paul-elliott-arm paul-elliott-arm added approved Design and code approved - may be waiting for CI or backports needs-ci Needs to pass CI tests labels Oct 14, 2022
@mpg mpg removed needs-ci Needs to pass CI tests needs-backports Backports are missing or are pending review and approval. labels Oct 17, 2022
@mpg mpg merged commit 6c6f04b into Mbed-TLS:development Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-daubney-arm tom-daubney-arm tom-daubney-arm approved these changes

@paul-elliott-arm paul-elliott-arm paul-elliott-arm approved these changes

Assignees

@mpg mpg

Labels
approved Design and code approved - may be waiting for CI or backports bug size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpg @paul-elliott-arm @tom-daubney-arm