[Backport 2.28] Remove radix argument from bignum test functions #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wernerlewis
added
enhancement
component-crypto
daverodgman
added
needs-review
All uses have radix argument removed, using script. Signed-off-by: Werner Lewis <[email protected]>
Cases where radix was explictly declared are removed in most cases, replaced using script. bignum arguments are represented as hexadecimal strings. This reduces clutter in test data and makes bit patterns clearer. Signed-off-by: Werner Lewis <[email protected]>
Functions which are not covered by script, changes made to use radix 16. Signed-off-by: Werner Lewis <[email protected]>
Signed-off-by: Werner Lewis <[email protected]>
Signed-off-by: Werner Lewis <[email protected]>
Test data which is compared as a hex string now uses upper case to match output of mbedtls_mpi_write_string() output. This removes usage of strcasecmp(). Signed-off-by: Werner Lewis <[email protected]>
wernerlewis
force-pushed
the
bignum_test_radix_2.28
branch
from
29a8000 to
df33684
Compare
tom-cosgrove-arm
approved these changes
Aug 2, 2022
tom-cosgrove-arm
removed
the
needs-reviewer
tom-daubney-arm
approved these changes
Aug 3, 2022
tom-daubney-arm
added
approved
|
CI was passing, not sure why it failed, so I've re-run the job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #6070.
Same scripts were ran on 2.28 for most replacements, with manual changes applied as required.
Status
READY