Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.28] Fix DTLS 1.2 session resumption #6067

Conversation

AndrzejKurek
Copy link
Contributor

@AndrzejKurek AndrzejKurek commented Jul 6, 2022

Straightforward backport of #5915, no conflicts.
I have verified that the bug exists, the ssl-opt.sh test fails without the fix, and that the fix works.

Andrzej Kurek added 4 commits July 6, 2022 06:43
Previously, the transforms were populated before extension
parsing, which resulted in the client rejecting a server
hello that contained a connection ID.
Signed-off-by: Andrzej Kurek <[email protected]>
Co-authored-by: Ronald Cron <[email protected]>
Signed-off-by: Andrzej Kurek <[email protected]>
…parsing

Use a more straightforward condition to note that session resumption
is happening.
Co-authored-by: Ronald Cron <[email protected]>
Signed-off-by: Andrzej Kurek <[email protected]>
@AndrzejKurek AndrzejKurek added bug needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests priority-high High priority - will be reviewed soon labels Jul 6, 2022
Signed-off-by: Andrzej Kurek <[email protected]>
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithful backport of #5915.

Copy link
Member

@paul-elliott-arm paul-elliott-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithful backport - Internal CI has passed.

@paul-elliott-arm paul-elliott-arm merged commit ada62f2 into Mbed-TLS:mbedtls-2.28 Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, priority-high High priority - will be reviewed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants