Backport 2.x: Remove config-psa-crypto.h #4456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
mbed TLS team
needs-review
gilles-peskine-arm
changed the title
ronald-cron-arm
previously approved these changes
May 4, 2021
|
Is it OK to remove this file in a stable branch? What was it used for, is it possible that some users relied on it? |
|
@mpg We've done it before: #1280, ARMmbed/mbed-crypto#71. We did announce it in the changelog, so I'll add a changelog entry. |
gilles-peskine-arm
added
needs-work
and removed
needs-review
This configuration file was useful in the early days of PSA crypto development. It stopped becoming relevant when MBEDTLS_PSA_CRYPTO_C entered the default configuration. Remove it: better late than never. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
force-pushed
the
remove-config-psa-crypto-2.x
branch
from
484e64f to
947360e
Compare
gilles-peskine-arm
added
needs-review
ronald-cron-arm
approved these changes
May 6, 2021
mpg
added
approved
|
Just holding out waiting for conflicts to be resolved in the main PR, as I think it's slightly cleaner to merge them both at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configuration file was useful in the early days of PSA crypto development. It stopped becoming relevant when
MBEDTLS_PSA_CRYPTO_Centered the default configuration. Remove it: better late than never.Backport of #4455