Add PSA Crypto driver delegation for MAC functions #4049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes stubbed test driver to verify all tests still pass Signed-off-by: Steven Cooreman <[email protected]>
Signed-off-by: Steven Cooreman <[email protected]>
daverodgman
added
Community
component-crypto
ronald-cron-arm
requested changes
Jan 29, 2021
There was a problem hiding this comment.
As for #4043, the driver delegation in this PR is not aligned with the organization of the PSA implementation with respect to the PSA driver interface that we are currently trying to move to. The code organization is described in the psa-crypto-implementation-structure.md document in PR #3933 and an example of its application for multi-part operation can be found here (for ciphers).
ronald-cron-arm
removed
the
needs-reviewer
2 tasks
|
Superseded by #4247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add driver delegation as per the already established paradigms and the design document in
docs/proposed/psa-driver-interface.md.Status
READY
Requires Backporting
NO
Migrations
NO
Todos
Steps to test or reproduce
Test coverage is provided by the existing PSA Crypto test suites. These tests provide confidence that the splicing-in of this driver delegation does not break the software implementation of these MAC algorithms.
Actually implementing a test driver is postponed, pending an architecture for how to test PSA Crypto accelerator drivers.