Skip to content

Commit

Permalink
Merge pull request #6412 from mpg/print-failed-suites-2.28
Browse files Browse the repository at this point in the history
[backport 2.28] Print the list of failed suites in verbose mode
  • Loading branch information
mpg authored Oct 13, 2022
2 parents 207b874 + 3211bbb commit a129bab
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions tests/scripts/run-test-suites.pl
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ =head1 SYNOPSIS

my $prefix = $^O eq "MSWin32" ? '' : './';

my ($failed_suites, $total_tests_run, $failed, $suite_cases_passed,
my (@failed_suites, $total_tests_run, $failed, $suite_cases_passed,
$suite_cases_failed, $suite_cases_skipped, $total_cases_passed,
$total_cases_failed, $total_cases_skipped );
my $suites_skipped = 0;
Expand Down Expand Up @@ -112,7 +112,7 @@ sub pad_print_center {
pad_print_center( 72, '-', "End $suite" );
}
} else {
$failed_suites++;
push @failed_suites, $suite;
print "FAIL\n";
if( $verbose ) {
pad_print_center( 72, '-', "Begin $suite" );
Expand All @@ -139,12 +139,17 @@ sub pad_print_center {
}

print "-" x 72, "\n";
print $failed_suites ? "FAILED" : "PASSED";
print @failed_suites ? "FAILED" : "PASSED";
printf( " (%d suites, %d tests run%s)\n",
scalar(@suites) - $suites_skipped,
$total_tests_run,
$suites_skipped ? ", $suites_skipped suites skipped" : "" );

if( $verbose && @failed_suites ) {
# the output can be very long, so provide a summary of which suites failed
print " failed suites : @failed_suites\n";
}

if( $verbose > 1 ) {
print " test cases passed :", $total_cases_passed, "\n";
print " failed :", $total_cases_failed, "\n";
Expand All @@ -159,5 +164,5 @@ sub pad_print_center {
}
}

exit( $failed_suites ? 1 : 0 );
exit( @failed_suites ? 1 : 0 );

0 comments on commit a129bab

Please sign in to comment.