-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schema and resolvers finder #152
base: feat/v3
Are you sure you want to change the base?
Conversation
@darkbasic that is some fantastic work! 👏🏻 |
Forgot to mention the PR on |
Hey @darkbasic I just wanted to ask if this feature was ever implemented into any other extensions. Seems like a useful feature but looks like it was never released for this extension at least? |
Hi, unfortunately this is still unreleased work. |
Would it be okay if I try to get this working locally on a extension? |
Sure, I would love to! |
Thank you! I have absolutely no experience with any of this but this type of feature would be extremely useful for me in a very large graphql codebase. Hopefully I can manage 😄 |
If you want want an head start back then I made a Youtube video showcasing my work. It probably won't add anything which isn't already covered in this PR, but I'm linking it nevertheless. |
Thank you for the video! As I understand, this extension was parsing the graphqlrc config and you added a new field called resolvers. Do you think this feature could also be implemented in the Vscode-graphql as that is a maintained extension? I've had an explanatory investigation to see if it would be possible but I'm not sure how big the scope of work would be to do so. Do you have any advice on this please? |
I think so but I cannot be sure until I dig deep into the extension internals. |
I didn't find any way to initiate a
showTextDocument
from the server, so for the moment I just show a message to the client with the resolver location: microsoft/language-server-protocol#612If we decide that we like the CodeLens approach I could give it a shot and submit a PR to implement it.