Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support svg download #1

Merged
merged 1 commit into from
Sep 28, 2021
Merged

feat: support svg download #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"plugins": ["import", "jsx-a11y", "react", "react-hooks", "prettier"],
"extends": ["airbnb", "prettier", "next", "next/core-web-vitals"],
"rules": {
"prettier/prettier": "error",
"prettier/prettier": ["error", {"endOfLine": "auto"}],
"camelcase": "off",
"import/prefer-default-export": "off",
"react/prop-types": "off",
Expand Down
27 changes: 22 additions & 5 deletions src/pages/components/AvatarEditor/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import DownloadModal from './DownloadModal';
export default function AvatarEditor() {
const [config, setConfig] = useState(getRandomStyle());
const [preview, setPreview] = useState(``);
const [imageType, setImageType] = useState(`png`);
const [showDownloadModal, setDownloadModal] = useState(false);
// default placeholder
const [imageDataURL, setImageDataURL] = useState(`/logo.gif`);
Expand Down Expand Up @@ -64,16 +65,27 @@ export default function AvatarEditor() {
width: dom.offsetWidth,
height: dom.offsetHeight,
});

const userAgent = window.navigator.userAgent.toLowerCase();
const isCompatible = CompatibleAgents.some(
(agent) => userAgent.indexOf(agent) >= 0,
);

// record download action
ga.event({ action: 'download', params: { ...config } });
// base64
const imageURL = canvas.toDataURL();

// base64 only support png svg for now, maybe more change it to Map
let imageURL;
if (imageType === "png") {
imageURL = canvas.toDataURL();
} else {
const svgElement = dom.querySelector("svg")
if (!svgElement) {
// not generate for some reason
return
}
const svg = new XMLSerializer().serializeToString(svgElement);
imageURL = `data:image/svg+xml;base64,${window.btoa(svg)}`
}

if (isCompatible) {
setImageDataURL(imageURL);
Expand All @@ -84,7 +96,7 @@ export default function AvatarEditor() {
const a = document.createElement('a');

a.href = imageURL;
a.download = `notion-avatar-${new Date().getTime()}.png`;
a.download = `notion-avatar-${new Date().getTime()}.${imageType}`;
a.click();
};

Expand Down Expand Up @@ -150,7 +162,12 @@ export default function AvatarEditor() {
width={28}
height={28}
/>
<span className="ml-3">{t('download')}</span>
<span className="ml-3">{t('download')}
<select onClick={(e) => (e.stopPropagation())} onChange={(e) => setImageType(e.target.value)}>
<option value="png">png</option>
<option value="svg">svg</option>
</select>
</span>
</button>
</div>
</div>
Expand Down