Skip to content

Commit

Permalink
deps: skip some V8 tests for ppc and s390
Browse files Browse the repository at this point in the history
PR-URL: nodejs#18453
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
  • Loading branch information
targos authored and MayaLekova committed May 8, 2018
1 parent d94b5b9 commit a0930a4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.2',
'v8_embedder_string': '-node.3',

# Enable disassembler for `--print-code` v8 options
'v8_enable_disassembler': 1,
Expand Down
4 changes: 4 additions & 0 deletions deps/v8/test/mjsunit/mjsunit.status
Original file line number Diff line number Diff line change
Expand Up @@ -682,6 +682,10 @@

# TODO(ppc/s390): implement atomic operations
'wasm/atomics': [SKIP],
'wasm/shared-memory': [SKIP],
# TODO(ppc/s390): fix constant pool issue and implement tagging for reloc
'wasm/compiled-module-serialization': [SKIP],
'regress/wasm/regress-808980': [SKIP],
}], # 'arch == ppc64 or arch == ppc or arch == s390 or arch == s390x'

##############################################################################
Expand Down

0 comments on commit a0930a4

Please sign in to comment.