assert: fix infinite loop

In rare cirumstances it is possible to get a identical error diff. In such a case the advances diffing runs into a infinite loop. This fixes it by properly checking for extra entries. PR-URL: nodejs#18611 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MayaLekova · May 8, 2018 · 9b6817c · 9b6817c
1 parent 240bca8
commit 9b6817c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -184,6 +184,8 @@ function createErrDiff(actual, expected, operator) {
     }
     actualLines.pop();
     expectedLines.pop();
+    if (actualLines.length === 0 || expectedLines.length === 0)
+      break;
     a = actualLines[actualLines.length - 1];
     b = expectedLines[expectedLines.length - 1];
   }

diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js
@@ -31,6 +31,7 @@ const { EOL } = require('os');
 const EventEmitter = require('events');
 const { errorCache } = require('internal/errors');
 const { writeFileSync, unlinkSync } = require('fs');
+const { inspect } = require('util');
 const a = assert;
 
 assert.ok(a.AssertionError.prototype instanceof Error,
@@ -565,6 +566,17 @@ common.expectsError(
     () => assert.deepEqual(Array(12).fill(1), Array(12).fill(2)),
     { message });
 
+  const obj1 = {};
+  const obj2 = { loop: 'forever' };
+  obj2[inspect.custom] = () => '{}';
+  // No infinite loop and no custom inspect.
+  assert.throws(() => assert.deepEqual(obj1, obj2), {
+    message: `${start}\n` +
+    `${actExp}\n` +
+    '\n' +
+    '  {}'
+  });
+
   // notDeepEqual tests
   message = 'Identical input passed to notDeepStrictEqual:\n[\n  1\n]';
   assert.throws(