benchmark: implement duration in http test double

PR-URL: nodejs#18380 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MayaLekova · May 8, 2018 · 7e98c6b · 7e98c6b
1 parent 51c0ff6
commit 7e98c6b
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 7 deletions.
diff --git a/benchmark/_http-benchmarkers.js b/benchmark/_http-benchmarkers.js
@@ -89,11 +89,14 @@ class TestDoubleBenchmarker {
   }
 
   create(options) {
+    const env = Object.assign({
+      duration: options.duration,
+      test_url: `http://127.0.0.1:${options.port}${options.path}`,
+    }, process.env);
+
     const child = child_process.fork(this.executable, {
       silent: true,
-      env: Object.assign({}, process.env, {
-        test_url: `http://127.0.0.1:${options.port}${options.path}`
-      })
+      env
     });
     return child;
   }

diff --git a/benchmark/_test-double-benchmarker.js b/benchmark/_test-double-benchmarker.js
@@ -2,6 +2,28 @@
 
 const http = require('http');
 
-http.get(process.env.test_url, function() {
-  console.log(JSON.stringify({ throughput: 1 }));
-});
+const duration = process.env.duration || 0;
+const url = process.env.test_url;
+
+const start = process.hrtime();
+let throughput = 0;
+
+function request(res) {
+  res.on('data', () => {});
+  res.on('error', () => {});
+  res.on('end', () => {
+    throughput++;
+    const diff = process.hrtime(start);
+    if (duration > 0 && diff[0] < duration) {
+      run();
+    } else {
+      console.log(JSON.stringify({ throughput }));
+    }
+  });
+}
+
+function run() {
+  http.get(url, request);
+}
+
+run();
diff --git a/test/sequential/test-benchmark-http.js b/test/sequential/test-benchmark-http.js
@@ -25,4 +25,7 @@ runBenchmark('http',
                'res=normal',
                'type=asc'
              ],
-             { NODEJS_BENCHMARK_ZERO_ALLOWED: 1 });
+             {
+               NODEJS_BENCHMARK_ZERO_ALLOWED: 1,
+               duration: 0
+             });