Skip to content

Commit

Permalink
test: rename test-regress-nodejsGH-4015
Browse files Browse the repository at this point in the history
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: nodejs#19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: nodejs#19161
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
  • Loading branch information
ryzokuken authored and MayaLekova committed May 8, 2018
1 parent cf00755 commit 7234e6a
Showing 1 changed file with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@
'use strict';
require('../common');
const { fixturesDir } = require('../common/fixtures');

// Check that the calls to Integer::New() and Date::New() succeed and bail out
// if they don't.
// V8 returns an empty handle on stack overflow. Trying to set the empty handle
// as a property on an object results in a NULL pointer dereference in release
// builds and an assert in debug builds.
// https://github.com/nodejs/node-v0.x-archive/issues/4015

const assert = require('assert');
const { exec } = require('child_process');

Expand Down

0 comments on commit 7234e6a

Please sign in to comment.