trigger a test CI run #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(ci): use PR addrs to compare layouts The `compare-layouts.yml` workflow runs via `workflow_run` and is thus triggered in the context of the base branch. It is, therefore, reading potentially outdated information from the `deployedContract.json` file. To avoid that, we use an intermediate artifact generated from the PR, which contains the updated addresses, during the step that fetches the storage layouts from Etherscan. Simpler validation, such as all required addresses are present and correctly formatted, is retained in the parent CI to permit quicker short circuit upon receiving invalid data. * feat: combine extract layout CI into one No need to have separate job for base and non-base branches * fix(ci): update matrix * fix(ci): use correct key for artifact * fix(ci): remove not working restore * fix(ci): checkout recursive module * fix(ci): exclude unnecessary file from artifact * fix(ci): rename layout to `.proposed.json` * remove superfluous line * fix(ci): drop `validatedContracts.json` correctly
|
✅ The Slither Analysis workflow has completed successfully. Check the workflow run for details. (c9a7211) |
|
✅ The Solhint workflow has completed successfully. Check the workflow run for details. (c9a7211) |
|
❌ The Forge CI workflow has failed! Check the workflow run for details. (c9a7211) |
|
⏭ The Compare Storage Layouts workflow was skipped. Check the workflow run for details. (c9a7211) |
To avoid unnecessary failure and workarounds, use `.compiled.json` where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.