fix(ci): use PR addrs to compare layouts #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `compare-layouts.yml` workflow runs via `workflow_run` and is thus triggered in the context of the base branch. It is, therefore, reading potentially outdated information from the `deployedContract.json` file. To avoid that, we use an intermediate artifact generated from the PR, which contains the updated addresses, during the step that fetches the storage layouts from Etherscan. Simpler validation, such as all required addresses are present and correctly formatted, is retained in the parent CI to permit quicker short circuit upon receiving invalid data.
|
✅ The Forge CI workflow has completed successfully. Check the workflow run for details. (81238ee) |
|
✅ The Solhint workflow has completed successfully. Check the workflow run for details. (81238ee) |
|
✅ The Slither Analysis workflow has completed successfully. Check the workflow run for details. (81238ee) |
|
❌ The Compare Storage Layouts workflow has failed! Check the workflow run for details. (81238ee) |
No need to have separate job for base and non-base branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compare-layouts.ymlworkflow runs viaworkflow_runand is thus triggered in the context of the base branch. It is, therefore, reading potentially outdated information from thedeployedContract.jsonfile. To avoid that, we use an intermediate artifact generated from the PR, which contains the updated addresses, during the step that fetches the storage layouts from Etherscan.Simpler validation, such as all required addresses are present and correctly formatted, is retained in the parent CI to permit quicker short circuit upon receiving invalid data.