New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add u256 multiplication #84

Merged

MaxGraey merged 2 commits into MaxGraey:master from peterjah:256_mul

Jun 16, 2023

Contributor

peterjah commented Jun 16, 2023

I took the logic from this golang lib:
https://github.com/holiman/uint256
it is the library used in go-ethereum to handle uint256 operation

peterjah force-pushed the 256_mul branch from 1196fcf to bb94e82 Compare

June 16, 2023 08:57

MaxGraey reviewed

View reviewed changes

assembly/globals.ts Outdated Show resolved Hide resolved

MaxGraey reviewed

View reviewed changes

assembly/globals.ts Outdated Show resolved Hide resolved

MaxGraey reviewed

View reviewed changes

assembly/globals.ts Outdated Show resolved Hide resolved

MaxGraey reviewed

View reviewed changes

assembly/globals.ts Outdated Show resolved Hide resolved

MaxGraey reviewed

View reviewed changes

assembly/globals.ts Outdated Show resolved Hide resolved

peterjah force-pushed the 256_mul branch from bb94e82 to 4b51445 Compare

June 16, 2023 10:45


          add u256 multiplication

4bd07f8

peterjah force-pushed the 256_mul branch from 4b51445 to 4bd07f8 Compare

June 16, 2023 13:24

MaxGraey reviewed

View reviewed changes

assembly/__tests__/u256.spec.ts Outdated Show resolved Hide resolved

MaxGraey reviewed

View reviewed changes

assembly/__tests__/u256.spec.ts Outdated Show resolved Hide resolved

Owner

MaxGraey commented Jun 16, 2023 •

edited

Loading

Could you also mention original https://github.com/holiman/uint256 in comments for __mul256?
Otherwise LGTM.

peterjah force-pushed the 256_mul branch 2 times, most recently from 851a6e8 to 0c070dd Compare

June 16, 2023 14:44


          add new test for u256 mul

055f675

peterjah force-pushed the 256_mul branch from 0c070dd to 055f675 Compare

June 16, 2023 14:45

MaxGraey merged commit 9767896 into MaxGraey:master

Owner

MaxGraey commented Jun 16, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet