Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to deployment #54

Open
Matthewar opened this issue Oct 1, 2018 · 2 comments
Open

Improvement to deployment #54

Matthewar opened this issue Oct 1, 2018 · 2 comments
Assignees

Comments

@Matthewar
Copy link
Owner

I have changed the deployment script to include additional information on the build along with copying the included docs into the pages branch (and therefore onto the ASV github pages site).

Test for this deployment script as part of the refactor in commit 379803f.
However this build failed because of issue #53.
Aforementioned issue requires fix before this can be tested.

Once this deployment script has been tested properly, need to undo the effects of the testing commit - only allowing deployments on master - and then this issue can be resolved.

@Matthewar
Copy link
Owner Author

Issue blocking fix has been closed, however build didn't run deployment, changing .travis.yml again to attempt to test.

Matthewar added a commit that referenced this issue Oct 1, 2018
Commenting out branch restriction didn't run deployment.
Changed branch to current refactor to test.
@Matthewar
Copy link
Owner Author

Successfully built and deployed in build #33.
Changes to be made:

  • Links in Other Pages section of main README.md are incorrect, need to have extension .html instead of .md
  • Only allow deployments on master branch (undo commit 379803f)

Matthewar added a commit that referenced this issue Oct 1, 2018
Testing complete, shown to work (see related issue).
Closes #54.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant