Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure in "Invalid bit strings" bit string literal test #52

Open
Matthewar opened this issue Sep 12, 2018 · 2 comments
Open

Failure in "Invalid bit strings" bit string literal test #52

Matthewar opened this issue Sep 12, 2018 · 2 comments
Assignees
Labels

Comments

@Matthewar
Copy link
Owner

  Parser tests
    Parser token types constructors
      Bit string constructor
        Invalid bit strings:                                            FAIL
          *** Failed! Falsifiable (after 9 tests):
          Exception thrown while showing test case:
            test/Spec/Parser/Types/Token.hs:(135,17)-(137,41): Non-exhaustive patterns in function findInvalid

          Use --quickcheck-replay=925432 to reproduce.

On commit 567baf1

@Matthewar Matthewar added the bug label Sep 12, 2018
@Matthewar Matthewar self-assigned this Sep 12, 2018
@Matthewar
Copy link
Owner Author

Presumably missing case is when list is empty which has no match, but the list should never be empty.

@Matthewar
Copy link
Owner Author

Issue must occur when the list is either empty, or only has valid characters.
Problem found in checkInvalid, there is no state where it is not true, if all characters are valid it eventually checks the empty list which counts as an invalid input as wanted.

Matthewar added a commit that referenced this issue Sep 12, 2018
Added pattern match for condition generating invalid bit strings.
Closes #52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant