Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of scope evaluation #28

Open
Matthewar opened this issue Apr 3, 2018 · 0 comments
Open

Order of scope evaluation #28

Matthewar opened this issue Apr 3, 2018 · 0 comments
Assignees
Labels

Comments

@Matthewar
Copy link
Owner

Use of maps when building scope tree could cause out-of-order scope evaluation, which leads to errors when scope names overwrite each other.

  • Currently overwriting scope objects with new ones if there is an overlap
  • This will cause unreliable scopes where it is indeterminate as to what object ends up in the scope
  • Should error when scope overlaps
  • Without correct scope ordering errors could point to wrong position
  • Should probably also change from using maps for scope
    Need to evaluate maps ordering and assess if this is an issue
@Matthewar Matthewar self-assigned this Apr 4, 2018
Matthewar added a commit that referenced this issue Apr 4, 2018
Added scope store for actual scope storage: stores all declarations in
the current scope (rather than scope names).
Need to deal with cylic dependencies (issue #27).
Currently may have issues with scope evaluation being loaded into map
(issue #28).
Matthewar added a commit that referenced this issue Apr 4, 2018
Changed scope types and by extension scope evaluation functions from
using a Data.Map.Strict to a list so that the scope can be evaluated in
order.
This should lead to better error messages and hopefully correct scope
ordering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant