-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made changes to winner messaging to show which player won #55
Conversation
Also made change to server start to reduce CPU usage in countdown
Should resolve #53 |
Additional changes to resolve less than 2 joining server |
I pulled master-pga and I'm still seeing the exact same issue as #53 |
Actually, it might be the case that it only happens now when a player wins after having placed a tiger at some point in the game. In this log Player 2 wins Game A by placing all totoro, 1 tiger, and all its villagers, but Player 1 is awarded the win. |
Updated to reflect correct winner in log. Seems to be scored correctly in tournament. Can you try again? |
https://pastebin.com/Lq4aQmYR |
Only seems to happen in situations where the winner placed a tiger or where the loser forfeited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Matt may have already fixed some of these but this should work
I just want to point out, in case nobody noticed, that this branch doesn't appear to have been merged with the master. |
Problems! |
Also made change to server start to reduce CPU usage in countdown