Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes to winner messaging to show which player won #55

Closed
wants to merge 3 commits into from

Conversation

thephil16
Copy link
Collaborator

Also made change to server start to reduce CPU usage in countdown

Also made change to server start to reduce CPU usage in countdown
@thephil16
Copy link
Collaborator Author

Should resolve #53

@thephil16
Copy link
Collaborator Author

Additional changes to resolve less than 2 joining server

@JohnZoldos
Copy link

I pulled master-pga and I'm still seeing the exact same issue as #53

@JohnZoldos
Copy link

Actually, it might be the case that it only happens now when a player wins after having placed a tiger at some point in the game. In this log Player 2 wins Game A by placing all totoro, 1 tiger, and all its villagers, but Player 1 is awarded the win.

https://pastebin.com/zd948E0J

@thephil16
Copy link
Collaborator Author

thephil16 commented Apr 14, 2017

Updated to reflect correct winner in log. Seems to be scored correctly in tournament. Can you try again?

@JohnZoldos
Copy link

https://pastebin.com/Lq4aQmYR
Still happening here. Player 1 forfeits but is listed as the winner.

@JohnZoldos
Copy link

Only seems to happen in situations where the winner placed a tiger or where the loser forfeited.

Copy link
Collaborator

@r3h4 r3h4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Matt may have already fixed some of these but this should work

@JohnZoldos
Copy link

I just want to point out, in case nobody noticed, that this branch doesn't appear to have been merged with the master.

@MatthewBregg
Copy link
Owner

MatthewBregg commented Apr 14, 2017

Problems!
Breaks everything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants