Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple theme #9

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Apple theme #9

wants to merge 5 commits into from

Conversation

danielhe3
Copy link

Submitting a theme based on Apple's keynote: https://www.apple.com/newsroom/2021/10/introducing-m1-pro-and-m1-max-the-most-powerful-chips-apple-has-ever-built/

It may be slightly boring and too close to theme_bw(), however, so I understand if it doesn't make the cut 👍

@lcpilling
Copy link
Collaborator

Hi. I actually really like the theme. I guess this is unique as you could use it in a work context and people wouldn't necessarily know it is pop culture (is an Apple theme pop culture?)

Before we accept. We have had several discussions over the last days about how to make the submissions syntax more consistent between the themes, and also more versatile for users. Christopher Kenny has provided a theme (Finding Nemo) which includes more fill scales for discreet, etc., and so we've updated the template to utilize this. It also prompts contributors to document the functions for when they are packaged up properly.

Would you consider updating your themes to use the new template? Hopefully not much work :)

https://github.com/MatthewBJane/theme_park/blob/main/theme_template.R

Thanks!
Luke

@danielhe3
Copy link
Author

Hi Luke, absolutely I can look into this. Agree that the template is really helpful to keep things consistent!

Daniel

@danielhe3
Copy link
Author

Hi Luke, sorry it took so long but I copied the new template and modified it to fit the theme. Let me know if I need to change anything.

@lcpilling
Copy link
Collaborator

Thanks Daniel! No apology necessary... this is just a hobby project for everyone. I have a three suggestions.

First, the background of the plots on (https://www.apple.com/newsroom/2021/10/introducing-m1-pro-and-m1-max-the-most-powerful-chips-apple-has-ever-built/) are #F7F7F7 rather than completely white, the text colour is ~ #888888 and the axis is #484848 (I think).

apple_theme_colors <- c(
  background = '#F7F7F7',
  text       = '#888888',
  axis       = '#484848'
)

ggplot(data = data.frame(x = rnorm(50, 0, 1), y = rnorm(50,0,1)), aes(x = x, y = y)) +
  geom_point() + 
  geom_smooth(method = 'lm') +
  labs(title="Apple scatter", subtitle="Theme by Daniel", caption="Data from rnorm()",
       x="Random variable X", y="Random variable Y") +
  theme_apple()

image

Second, the other themes included in the package include more colours in the theme colors object, such as light, medium and dark which helps users quickly access a few useful colours. Going off the purple line from the link, you could add the following?

apple_theme_colors <- c(
  background = '#F7F7F7',
  text       = '#888888',
  axis       = '#484848',
  light      = '#CBA5FC',
  medium     = '#A766FF',
  dark       = '#6501FF'
)

So people can do something like:

ggplot(data = data.frame(x = rnorm(50, 0, 1), y = rnorm(50,0,1)), aes(x = x, y = y)) +
  geom_point(color = apple_theme_colors["medium"]) + 
  geom_smooth(method = 'lm',
              color = apple_theme_colors["dark"], 
              fill = apple_theme_colors["light"]) +
  labs(title="Apple scatter", subtitle="Theme by Daniel") +
  theme_apple()

image

Third! Remove the axis ticks from the theme - again to be more similar to the plot you linked to:

ggplot(data = data.frame(x = rnorm(50, 0, 1), y = rnorm(50,0,1)), aes(x = x, y = y)) +
  geom_point(color = apple_theme_colors["medium"]) + 
  geom_smooth(method = 'lm',
              color = apple_theme_colors["dark"], 
              fill = apple_theme_colors["light"]) +
  labs(title="Apple scatter", subtitle="Theme by Daniel", caption="Data from rnorm()",
       x="Random variable X", y="Random variable Y") +
  theme_apple() +
  theme(axis.ticks = element_blank())

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants