Added toLowerCase for vnode.tagName to support webcomponents #413
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually think this could be a bug in Chrome's implementation of Custom Elements, but I thought I'd open a PR to at least open a discussion on it. If it is indeed a Chrome issue, then of course I don't expect this to be merged — however I couldn't find a related Chrome bug.
The issue:
Whilst in most cases HTML is case insensitive, using Custom Elements v1's
customElements.define
it seems that custom elements are case-sensitive when usingdocument.createElement
as shown in the following Fiddle (note: requires Chrome Canary, ascustomElements.define
won't work in Chrome yet).By adding
toLowerCase
invirtual-dom
'svnode.tagName
theconnectedCallback
function is invoked as expected. Interestingly, in the Fiddle it doesn't matter how the HTML is written (rightfully so), as both<example-node />
and<EXAMPLE-NODE />
are equals, and thus work perfectly.Thoughts?