Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client establishes and completes creation before handshake fails. #12

Closed
tegefaulkes opened this issue Apr 24, 2023 · 1 comment
Closed

Client establishes and completes creation before handshake fails. #12

tegefaulkes opened this issue Apr 24, 2023 · 1 comment
Assignees
@tegefaulkes
Labels
development Standard development r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices

Comments

@tegefaulkes
Copy link
Contributor

Specification

The client quiche connection establishes before the handshake completes. This means that QUICClient creation can't know that the TLS handshake has failed before it completes. Currently this is only a problem for the server authenticating the client since the failure will happen after the client connection establishes.

The problem is not critical however since the connection will soon fail with the expect error. It just causes problems with error reporting related to the life-cycle of the QUICClient since the expectation is that the client creation will fail if the connection fails. TLS failure is considered part of that.

I'm creating this issue just to track the problem and the upstream issue.

Additional context

Tasks

  1. Wait for a response to the upstream issue.
@tegefaulkes tegefaulkes added the development Standard development label Apr 24, 2023
@tegefaulkes tegefaulkes self-assigned this Apr 24, 2023
@tegefaulkes tegefaulkes mentioned this issue Apr 24, 2023
Closed
3 tasks
tegefaulkes added a commit that referenced this issue Apr 24, 2023
@tegefaulkes
tests: disabling client authentication tests, they require #12
f3038bd 
* Related #9

[ci skip]
tegefaulkes added a commit that referenced this issue Apr 26, 2023
@tegefaulkes
tests: disabling client authentication tests, they require #12
6d5c6b5 
* Related #9

[ci skip]
tegefaulkes added a commit that referenced this issue Apr 26, 2023
@tegefaulkes
tests: disabling client authentication tests, they require #12
60f9370 
* Fixes #9

[ci skip]
CMCDragonkai pushed a commit that referenced this issue May 17, 2023
@tegefaulkes @CMCDragonkai
tests: disabling client authentication tests, they require #12
0c003a4 
* Fixes #9

[ci skip]
@CMCDragonkai
Copy link
Member

CMCDragonkai commented Jul 6, 2023 •
edited
Loading

This is resolved by #26 right?

@CMCDragonkai CMCDragonkai added the r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tegefaulkes tegefaulkes

Labels
development Standard development r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CMCDragonkai @tegefaulkes