Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 22.05 #71

Merged
merged 2 commits into from
Jul 10, 2022
Merged

Feature 22.05 #71

merged 2 commits into from
Jul 10, 2022

Conversation

CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented Jul 10, 2022

Description

Upgrades to 22.05 revision ce6aa13369b667ac2542593170993504932eb836 and adds the created = "now";.

Issues Fixed

Tasks

  • 1. Changed pkgs.nix to use the 22.05 revision as are using on our OS
  • 2. Added created = "now"; that introduces proper timestamps on our docker images, but binary reproducibility (content hashes) will change, input hashing is preserved

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@CMCDragonkai CMCDragonkai self-assigned this Jul 10, 2022
@CMCDragonkai CMCDragonkai merged commit 1fec8ca into staging Jul 10, 2022
@ghost
Copy link

ghost commented Jul 10, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@CMCDragonkai
Copy link
Member Author

The new gitlab-runner and matching revisions give us this result:

We are now only downloading 68 MiB vs originally 239 MiB on the TS demo lib check:lint job.

image

image

  • The job logs are much shorter
  • This particular linux job is pretty small, so overall clock time didn't change much, instead... an increased time was spent pulling the container image from the registry

However less bandwidth used, and I'm sure this will scale up to larger projects in the future, plus we have a more comprehensive image with all the relevant configuration with timezones, TLS, iana, locality... and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant