Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backgrounding of Notifications Domain #695

Merged
merged 15 commits into from
Apr 29, 2024
Merged

Backgrounding of Notifications Domain #695

merged 15 commits into from
Apr 29, 2024

Commits on Apr 29, 2024

  1. feat: NotificationsManager.sendNotification is no longer blocking 

    fix: exponential backoff for notifications

fix: outbox notifications are now given ids

fix: notification tasks are now no longer lazy

fix: sendNotification now returns notificationId

fix: outbox notifications now use DB state

fix: NotificationId is now included in Notification, with the id and senderId fields

fix: `NotificationsManager` `Notification`s now have different types for state in DB and in usage

fix: tests
    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    a1e1161 View commit details
    Browse the repository at this point in the history

  2. feat: notificationsOutboxClear RPC handler and caller

    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8bff2aa View commit details
    Browse the repository at this point in the history

  3. fix: api for NotificationsManager.sendNotification now takes an object

    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d0bf6f2 View commit details
    Browse the repository at this point in the history

  4. fix: NotificationsManager.sendNotification now returns a sendProm… 

    … rather than blocking directly from the returned promise

fix: `NotificationsManager` tests
    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    4e8e87b View commit details
    Browse the repository at this point in the history

  5. feat: notificationsOutboxRead RPC caller and handler

    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7d17430 View commit details
    Browse the repository at this point in the history

  6. fix: NotificationsManager outbox send logic simplification 

    fix: removed idUtils toBuffer usage

fix: changed position of sendNotificationHandlerId

fix: notificationsManager sendProm name

fix: removed count from NotificationsManager

fix: simplified NotificationId to TaskId reference

fix: sendNotificationHandler logic

fix: NotificationsManager db levelpath docblocks

fix: defaultRetries on NotifciationsManager constructor
    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    541b952 View commit details
    Browse the repository at this point in the history

  7. feat: changed readNotifications and readOutboxNotifications to re… 

    …turn

AsyncGenerator

fix: removed unneeded creation of transaction in private methods

fix: notificationsRead handler now uses asyncgenerator

fix: readded blocking to NotificationsSend handler

fix: tests and exports for notifications outbox handlers
    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    51fbe96 View commit details
    Browse the repository at this point in the history

  8. fix: NotificationsManager.sendNotification delay is now double rath… 

    …er than exponential
    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    325c5c3 View commit details
    Browse the repository at this point in the history

  9. feat: NotificationsManager.removeNotification and 

    `NotificationsRemove` RPC handlers
    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6af465d View commit details
    Browse the repository at this point in the history

  10. fix: renamed notificationsRead, notificationsClear and `notificat… 

    …ionsRemove` RPC calls to `notificationsInboxRead`, `notificationsInboxClear` and `notificationsInboxRemove` respectively
    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    789d8b8 View commit details
    Browse the repository at this point in the history

  11. fix: default sendRetryIntervalTimeMin and `sendRetryIntervalTimeMax… 

    …` values + notifcation send retry tests
    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    15499a6 View commit details
    Browse the repository at this point in the history

  12. fix: NotificationsManager sendHandler doesn't need transaction block

    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    92abd24 View commit details
    Browse the repository at this point in the history

  13. feat: added taskMetadata to notificationsOutboxRead rpc call 

    fix: `notifications.test.ts` for RPC handlers involving notification IDs
    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    44d7b70 View commit details
    Browse the repository at this point in the history

  14. feat: standardization of NotificationsManager method params to be more 

    like `Audit` domain
    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    c83371d View commit details
    Browse the repository at this point in the history

  15. feat: added seek and seekEnd to NotificationsManager

    @amydevs
    amydevs committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    4a53e72 View commit details
    Browse the repository at this point in the history