Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace uws with ws #540

Closed
tegefaulkes opened this issue Aug 1, 2023 · 1 comment · Fixed by #535
Closed

Replace uws with ws #540

tegefaulkes opened this issue Aug 1, 2023 · 1 comment · Fixed by #535
Assignees
@tegefaulkes
Labels
development Standard development r&d:polykey:supporting activity Supporting core activity

Comments

@tegefaulkes
Copy link
Contributor

Specification

After some discussion we've concluded that uws is not fit for use. We should look into replacing the server side websocket code with ws.

This needs to be further specced out.

Additional context

Tasks

  1. Replace uws with ws.
@tegefaulkes tegefaulkes added the development Standard development label Aug 1, 2023
This was referenced Aug 16, 2023
Closed
Merged
@tegefaulkes tegefaulkes self-assigned this Aug 10, 2023
tegefaulkes added a commit that referenced this issue Aug 10, 2023
@tegefaulkes
wip: removing uws
afdd66b 
* Related #540

[ci skip]
tegefaulkes added a commit that referenced this issue Aug 11, 2023
@tegefaulkes
feat: replaced uws with ws
5a043b4 
* Related #540

[ci skip]
tegefaulkes added a commit that referenced this issue Aug 11, 2023
@tegefaulkes
refactor: combined the websocket client and server stream implementation
484cbdc 
* Related #540

[ci skip]
tegefaulkes added a commit that referenced this issue Aug 11, 2023
@tegefaulkes
fix: host and port are only set for the https server
345d36b 
* Related #540

[ci skip]
tegefaulkes added a commit that referenced this issue Aug 11, 2023
@tegefaulkes
fix: WebSocketServer can now update TLS certs while running
f8555f1 
* Related #540

[ci skip]
@tegefaulkes
Copy link
Contributor Author

This is pretty much done now. I've also fixed the ability to update the TLS certs while running so that is re-enabled.

I'm going to review the existing websocket issues and see that will be resolved or wont fix.

This was referenced Aug 11, 2023
Closed
Open
CMCDragonkai pushed a commit that referenced this issue Aug 15, 2023
@tegefaulkes @CMCDragonkai
wip: removing uws
c22729b 
* Related #540

[ci skip]
CMCDragonkai pushed a commit that referenced this issue Aug 15, 2023
@tegefaulkes @CMCDragonkai
feat: replaced uws with ws
b73d10a 
* Related #540

[ci skip]
CMCDragonkai pushed a commit that referenced this issue Aug 15, 2023
@tegefaulkes @CMCDragonkai
refactor: combined the websocket client and server stream implementation
70bd656 
* Related #540

[ci skip]
CMCDragonkai pushed a commit that referenced this issue Aug 15, 2023
@tegefaulkes @CMCDragonkai
fix: host and port are only set for the https server
e5ad709 
* Related #540

[ci skip]
CMCDragonkai pushed a commit that referenced this issue Aug 15, 2023
@tegefaulkes @CMCDragonkai
fix: WebSocketServer can now update TLS certs while running
17be622 
* Related #540

[ci skip]
@amydevs amydevs mentioned this issue Aug 17, 2023
Merged
39 tasks
tegefaulkes added a commit that referenced this issue Aug 18, 2023
@tegefaulkes
feat: replaced uws with ws
d955507 
* Related #540

[ci skip]
tegefaulkes added a commit that referenced this issue Aug 18, 2023
@tegefaulkes
refactor: combined the websocket client and server stream implementation
6b39b73 
* Related #540

[ci skip]
tegefaulkes added a commit that referenced this issue Aug 18, 2023
@tegefaulkes
fix: host and port are only set for the https server
919f3f4 
* Related #540

[ci skip]
tegefaulkes added a commit that referenced this issue Aug 18, 2023
@tegefaulkes
fix: WebSocketServer can now update TLS certs while running
f7d044b 
* Related #540

[ci skip]
CMCDragonkai pushed a commit that referenced this issue Oct 4, 2023
@tegefaulkes @CMCDragonkai
feat: replaced uws with ws
89eb2b9 
* Related #540

[ci skip]
@CMCDragonkai CMCDragonkai added the r&d:polykey:supporting activity Supporting core activity label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tegefaulkes tegefaulkes

Labels
development Standard development r&d:polykey:supporting activity Supporting core activity
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Agent migration stage 2 MatrixAI/Polykey
2 participants
@CMCDragonkai @tegefaulkes