Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set an alias for a particular peer #132

Closed
robert-cronin opened this issue Nov 19, 2020 · 2 comments
Closed

Set an alias for a particular peer #132

robert-cronin opened this issue Nov 19, 2020 · 2 comments
Assignees
@robert-cronin
Labels
development Standard development enhancement New feature or request

Comments

@robert-cronin
Copy link
Contributor

at the moment, the only way to identify a peer in the store is via a hash string of the public key (peerId), but this is not very user friendly. A great idea from @gideonairex is to extract the userId from the public key and set that at the top of each PeerInfo to be browsed by the user or even add in the ability to set a local alias for a particular peer.
This might be accomplished through the use of an extra map in PeerManager. If we wan't to keep the alias local, then it shouldn't be added to the PeerInfo as that might be shared to others.
So our aliasStore might be a mapping of peerIds to alias strings.
@robert-cronin robert-cronin added enhancement New feature or request development Standard development labels Nov 19, 2020
@robert-cronin robert-cronin self-assigned this Nov 19, 2020
@robert-cronin robert-cronin mentioned this issue Nov 19, 2020
Closed
10 tasks
@robert-cronin robert-cronin added this to the Polykey MVP 2 - Release Candidate milestone Dec 7, 2020
@robert-cronin
Copy link
Contributor Author

Still a bug with getting peers from peer store based on alias.

@robert-cronin
Copy link
Contributor Author

Closing on account of migration to gitlab

CMCDragonkai pushed a commit that referenced this issue Jan 8, 2021
@robert-cronin
Merge branch 'udp-direct-hole-punch' into 'master'
06f01dc 
Fix: UDP direct hole punching, high CPU usage and misc.

Closes #135, #134, #133, #132, #129, #127, #126, #123, #121, and #120

See merge request MatrixAI/Engineering/Polykey/js-polykey!130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robert-cronin robert-cronin

Labels
development Standard development enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: UDP direct hole punching, high CPU usage and misc. MatrixAI/Polykey
1 participant
@robert-cronin