Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

social discovery is not working as intended #131

Closed
robert-cronin opened this issue Nov 12, 2020 · 2 comments
Closed

social discovery is not working as intended #131

robert-cronin opened this issue Nov 12, 2020 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@robert-cronin
Copy link
Contributor

At the moment we have exposed pk peers social interface for finding peer users via social discovery services like keybase, but it is not working as intended and failing with an error of fetch is not defined. We will also need to find some way to put social proof on a user's keybase (our first integration) by means of a signed polykey.proof file in the user's public path so it can be directly access via a call to https://<username>.keybase.pub/polykey.proof as kbfs exposes this interface publicly.

Another enhancement might be to transfer the social sub command onto pk peers find ... instead of just pk peers social ... so as to disambiguate the meaning of the command from first glance.

Also less important, -h, --handle param is interfering with help command, I suggest renaming to -hn, --handle

@robert-cronin robert-cronin added bug Something isn't working enhancement New feature or request dependencies labels Nov 12, 2020
@robert-cronin robert-cronin self-assigned this Nov 12, 2020
@robert-cronin robert-cronin added this to the Polykey MVP 2 - Release Candidate milestone Dec 7, 2020
@CMCDragonkai
Copy link
Member

According to our new polykey-design and DI augmentation process, any social part of polykey needs to be abstracted using a strategy pattern. Basically any code that does social needs to be a like plugin. Other people can contribute new social plugins that can be included in a PK distribution or installed. For now we will release our own plugins. So keybase should be just one of the possible IdPs.

@robert-cronin
Copy link
Contributor Author

Closing on account of migration to gitlab

CMCDragonkai pushed a commit that referenced this issue Jan 18, 2021
Update Sharing System

Closes #131, #122, and #33

See merge request MatrixAI/Engineering/Polykey/js-polykey!134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Development

No branches or pull requests

2 participants