Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to revive Polykey Desktop. It's been about a year and we are interested in making some changes and having a base to develop UI interactions like for debugging.
Some things I'm experimenting with here:
tsconfig.build.json
, which it is configured to do sotsc -p ./tsconfig.json
which doesn't do any building. This also means a bunch of tsconfig isn't really needed like incremental compilation and such. The esbuild just strips types and does its own build. The tsc is left just for type checking.index.html
this has to be produced from esbuild. To do this, we need to use https://www.npmjs.com/package/@craftamap/esbuild-plugin-html in a similar way to how the original html webpack plugin used to work.scripts/build.js
, this reduces the number of dependencies we need by a significant amount.node_modules
, so we need to adjust thedefault.nix
polykey
as that is the core library.Issues Fixed
Tasks
Final checklist