Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update after NumPy 2.0+ removal of ndarray.newbyteorder #55

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

dalcinl
Copy link
Collaborator

@dalcinl dalcinl commented Nov 18, 2024

No description provided.

@dalcinl dalcinl force-pushed the fix-numpy-newbyteorder branch from 277d5de to e380f58 Compare November 18, 2024 15:40
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.67%. Comparing base (8a476cb) to head (e380f58).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   76.72%   76.67%   -0.06%     
==========================================
  Files          16       16              
  Lines        3532     3532              
  Branches      554      465      -89     
==========================================
- Hits         2710     2708       -2     
- Misses        664      666       +2     
  Partials      158      158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dalcinl
Copy link
Collaborator Author

dalcinl commented Nov 18, 2024

@mengaldo @mrogowski Looks like MPI tests have been broken for quite some time, mostly related to issues with dependencies. This PR handles only things related to changes in NumPy. I'll merge it as-is, but other things will still leave CI in a broken state.

@dalcinl dalcinl merged commit 9d69ac0 into main Nov 18, 2024
10 of 25 checks passed
@dalcinl dalcinl deleted the fix-numpy-newbyteorder branch November 18, 2024 15:54
@mrogowski
Copy link
Collaborator

Thanks @dalcinl! I'll try to take a look this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants