Advance time once all variables have been read #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage 76.72% 76.72%
=======================================
Files 16 16
Lines 3532 3532
Branches 554 554
=======================================
Hits 2710 2710
Misses 664 664
Partials 158 158 ☔ View full report in Codecov by Sentry. |
dalcinl
reviewed
Apr 21, 2024
| @@ -278,7 +278,7 @@ def get_data_for_time(self, ts, te): | |||
| vals = dvars[var].values | |||
| input_data[cum_read:cum_read+read_cnt,:,idx] = vals.reshape(vals.shape[0],-1)#.copy() | |||
| del vals | |||
| cum_read = cum_read + read_cnt | |||
| cum_read = cum_read + read_cnt | |||
dalcinl
force-pushed
the
fix-reader-multivar
branch
from
cd241b3 to
49c2efd
Compare
|
@mrogowski Should we merge this one? |
|
Yes, I forgot we didn't already! |
dalcinl
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.