Expand Connections Test Coverage (Connections) #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyiliev
force-pushed
the
Connections-Test-Coverage
branch
from
b29946a
to
8a76761
Compare
dehume
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Looking good. The additional tests in the integration/connection.tf should be helpful. The thing that will be hardest with connections is the recent work with ALTER CONNECTION... (#368). But we can keep that to a separate issue and include all the additional acceptance tests required then.
|
Sounds good! Will grab that issue now. |
dehume
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.