Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Test Coverage #387

Merged
merged 17 commits into from
Nov 28, 2023
Merged

Expand Test Coverage #387

merged 17 commits into from
Nov 28, 2023

Conversation

dehume
Copy link
Contributor

@dehume dehume commented Nov 27, 2023

Adding additional test coverage for:

  • Cluster Replicas
  • Clusters
  • Databases
  • Grants
  • Grant Defaults
  • Indexes
  • Materialized Views
  • Roles
  • Schemas
  • Secrets
  • Tables
  • Types
  • Views
  • Sources

Ensure that all resources have acceptance tests to cover all attributes for creation and modification within Terraform. Expanding unit tests for more complex resources based on tests from Materialize test drive. Also several updates to resources based on rereading documentation and looking at examples in Materialize tests:

  • materialize_role
    [Breaking Change] Remove session_variables attribute. Being able to set this attribute is not helpful in the context of Terraform.

  • materialize_table
    Allow default to be set for columns within a table.

  • materialize_type
    Support the type of row.

  • materialize_source_load_generator
    Include expose_progress attribute.

#374

@dehume dehume added breaking change Will cause a breaking change in the next release testing Issue related to tests labels Nov 27, 2023
@dehume dehume marked this pull request as ready for review November 27, 2023 20:54
@dehume dehume added the enhancement New feature or request label Nov 27, 2023
@dehume dehume removed the enhancement New feature or request label Nov 28, 2023
Dennis Hume and others added 2 commits November 28, 2023 12:52
@dehume dehume changed the title [WIP] Expand Test Coverage Expand Test Coverage Nov 28, 2023
@dehume dehume merged commit fc7bffb into main Nov 28, 2023
6 checks passed
@dehume dehume deleted the Test-Coverage branch November 28, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Will cause a breaking change in the next release testing Issue related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants