-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Test Coverage #387
Merged
Merged
Expand Test Coverage #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehume
added
breaking change
Will cause a breaking change in the next release
testing
Issue related to tests
labels
Nov 27, 2023
bobbyiliev
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional test coverage for:
Ensure that all resources have acceptance tests to cover all attributes for creation and modification within Terraform. Expanding unit tests for more complex resources based on tests from Materialize test drive. Also several updates to resources based on rereading documentation and looking at examples in Materialize tests:
materialize_role
[Breaking Change] Remove
session_variables
attribute. Being able to set this attribute is not helpful in the context of Terraform.materialize_table
Allow
default
to be set for columns within a table.materialize_type
Support the type of
row
.materialize_source_load_generator
Include
expose_progress
attribute.#374