Eliminate more typ and arity calls
#30884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggevay
commented
Dec 20, 2024
| @@ -219,7 +219,8 @@ impl Demand { | |||
| for expr in exprs { | |||
| expr.support_into(&mut columns); | |||
| } | |||
| columns.retain(|c| *c < input.arity()); | |||
ggevay
force-pushed
the
typ-demand-literal-constr
branch
3 times, most recently
from
69ad6a7 to
893d0d0
Compare
ggevay
force-pushed
the
typ-demand-literal-constr
branch
from
893d0d0 to
50072db
Compare
mgree
approved these changes
Jan 9, 2025
| @@ -329,6 +329,8 @@ impl MapFilterProject { | |||
| let (mfp, expr) = Self::extract_from_expression(input); | |||
| (mfp.project(outputs.iter().cloned()), expr) | |||
| } | |||
| // TODO: The recursion is quadratic in the number of Map/Filter/Project operators due to | |||
There was a problem hiding this comment.
I made an issue: https://github.com/MaterializeInc/database-issues/issues/8868.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #30881, because it relies on the new variations of
take_safely.Nightly (subset): https://buildkite.com/materialize/nightly/builds/10717
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.