source/pg: proactively validate schemas #30807
Merged
+107
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrosagg
force-pushed
the
pg-proactive-schema-validation
branch
2 times, most recently
from
549d9bd to
621bcb1
Compare
teskje
approved these changes
Dec 16, 2024
Comment on lines
513
to
514
| // If the publication is missing there is nothing else to | ||
| // do. These errors are not retractable. |
There was a problem hiding this comment.
I suggest dropping one of these two comments, since they seem redundant.
The PostgreSQL logical replication protocol only notifies us that a table has changed schema if that table participates in a transaction *after* the schema change has occured. This is problematic because until that table participates in a transaction Materialize will keep advancing the upper frontier of the table, asserting that everything is fine and potentially revealing invalid data. This PR puts an upper bound on this window of invalidity by proactively re-validating the schema of all tables in an ingestion in a cadence. The interval is set to 15s by default but configurable through LD. Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
force-pushed
the
pg-proactive-schema-validation
branch
from
621bcb1 to
9799a0a
Compare
def-
added a commit
to def-/materialize
that referenced
this pull request
Jan 10, 2025
5 tasks
def-
added a commit
to def-/materialize
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PostgreSQL logical replication protocol only notifies us that a table has changed schema if that table participates in a transaction after the schema change has occured.
This is problematic because until that table participates in a transaction Materialize will keep advancing the upper frontier of the table, asserting that everything is fine and potentially revealing invalid data.
This PR puts an upper bound on this window of invalidity by proactively re-validating the schema of all tables in an ingestion in a cadence. The interval is set to 15s by default but configurable through LD.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.