-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the new instrospection sources #30393
Disable the new instrospection sources #30393
Conversation
This commit disables the newly added introspection sources `mz_compute_dataflow_global_ids_per_worker` and `mz_compute_lir_mapping_per_worker`, because Mz's 0dt mechanism is currently not prepared to handle new introspection sources. "Disabling" here means removing the registration of the new `Log` builtins and the `View`s depending on them. The intention is to keep the diff as small as possible, to make this change less risky.
bbcbe7b
to
46a63c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me assuming platform-checks 0dt upgrades in nightly are green: https://buildkite.com/materialize/nightly/builds/10317
We are still seeing the logging:
But I think that's actually not a sign of this not working, but instead we already have a v0.124.0 cut that has the problem. So ok from my side. |
Disable the new instrospection sources
This PR disables the two introspection sources added in #29848, because Mz's 0dt mechanism is currently not prepared to handle new introspection sources.
"Disabling" here means removing the registration of the new
Log
builtins and theView
s depending on them. The intention is to keep the diff as small as possible, to make this change less risky.The plan is to revert this PR once https://github.com/MaterializeInc/database-issues/issues/8731 is resolved.
Motivation
Mitigates https://github.com/MaterializeInc/database-issues/issues/8731 for the release.
Tips for reviewer
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.