Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the new instrospection sources #30393

Merged

Conversation

teskje
Copy link
Contributor

@teskje teskje commented Nov 8, 2024

This PR disables the two introspection sources added in #29848, because Mz's 0dt mechanism is currently not prepared to handle new introspection sources.

"Disabling" here means removing the registration of the new Log builtins and the Views depending on them. The intention is to keep the diff as small as possible, to make this change less risky.

The plan is to revert this PR once https://github.com/MaterializeInc/database-issues/issues/8731 is resolved.

Motivation

  • This PR fixes a recognized bug.

Mitigates https://github.com/MaterializeInc/database-issues/issues/8731 for the release.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

This commit disables the newly added introspection sources
`mz_compute_dataflow_global_ids_per_worker` and
`mz_compute_lir_mapping_per_worker`, because Mz's 0dt mechanism is
currently not prepared to handle new introspection sources.

"Disabling" here means removing the registration of the new `Log`
builtins and the `View`s depending on them. The intention is to keep the
diff as small as possible, to make this change less risky.
@teskje teskje force-pushed the disable-new-introspection-sources branch from bbcbe7b to 46a63c8 Compare November 8, 2024 14:35
@teskje teskje marked this pull request as ready for review November 8, 2024 14:35
@teskje teskje requested review from a team as code owners November 8, 2024 14:35
@teskje teskje requested a review from jkosh44 November 8, 2024 14:35
Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me assuming platform-checks 0dt upgrades in nightly are green: https://buildkite.com/materialize/nightly/builds/10317

@def- def- mentioned this pull request Nov 8, 2024
5 tasks
@def-
Copy link
Contributor

def- commented Nov 8, 2024

We are still seeing the logging:

platform-checks-mz_2-1              | cluster-s3-replica-s3-gen-1: 2024-11-08T15:00:40.661245Z  WARN mz_compute::server: halting process: new instance configuration does not match existing instance configuration:

But I think that's actually not a sign of this not working, but instead we already have a v0.124.0 cut that has the problem. So ok from my side.

@teskje teskje merged commit d3bea77 into MaterializeInc:main Nov 8, 2024
95 of 97 checks passed
antiguru pushed a commit that referenced this pull request Nov 8, 2024
@teskje teskje deleted the disable-new-introspection-sources branch November 11, 2024 09:17
jkosh44 added a commit to jkosh44/materialize that referenced this pull request Nov 13, 2024
…ew-introspection-sources"

This reverts commit d3bea77, reversing
changes made to 0883e66.
teskje added a commit to teskje/materialize that referenced this pull request Nov 18, 2024
…ew-introspection-sources"

This reverts commit d3bea77, reversing
changes made to 0883e66.
jkosh44 added a commit to jkosh44/materialize that referenced this pull request Nov 25, 2024
…ew-introspection-sources"

This reverts commit d3bea77, reversing
changes made to 0883e66.
jkosh44 added a commit to jkosh44/materialize that referenced this pull request Nov 25, 2024
…ew-introspection-sources"

This reverts commit d3bea77, reversing
changes made to 0883e66.
jkosh44 added a commit to jkosh44/materialize that referenced this pull request Nov 25, 2024
…ew-introspection-sources"

This reverts commit d3bea77, reversing
changes made to 0883e66.
jkosh44 added a commit to jkosh44/materialize that referenced this pull request Nov 25, 2024
…ew-introspection-sources"

This reverts commit d3bea77, reversing
changes made to 0883e66.
jkosh44 added a commit to jkosh44/materialize that referenced this pull request Nov 25, 2024
…ew-introspection-sources"

This reverts commit d3bea77, reversing
changes made to 0883e66.
jkosh44 added a commit to jkosh44/materialize that referenced this pull request Nov 25, 2024
…ew-introspection-sources"

This reverts commit d3bea77, reversing
changes made to 0883e66.
jkosh44 added a commit to jkosh44/materialize that referenced this pull request Nov 25, 2024
…ew-introspection-sources"

This reverts commit d3bea77, reversing
changes made to 0883e66.
jkosh44 added a commit to jkosh44/materialize that referenced this pull request Nov 25, 2024
…ew-introspection-sources"

This reverts commit d3bea77, reversing
changes made to 0883e66.
jkosh44 added a commit to jkosh44/materialize that referenced this pull request Nov 26, 2024
…ew-introspection-sources"

This reverts commit d3bea77, reversing
changes made to 0883e66.
jkosh44 added a commit to jkosh44/materialize that referenced this pull request Nov 27, 2024
…ew-introspection-sources"

This reverts commit d3bea77, reversing
changes made to 0883e66.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants