Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move materialize issue references to database-issues #29773

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

def-
Copy link
Contributor

@def- def- commented Sep 29, 2024

Collected the issues via

git grep "https://github.com/MaterializeInc/materialize/issues/" | sed -e "s/.*issues\/\([0-9]*\).*/\1/g" | sort -n | uniq
git grep "materialize#" | sed -e "s/.*materialize#\([0-9]*\).*/\1/g" | sort -n | uniq > out

Then found the correct new urls via

while read line; do curl --header "Authorization: Bearer $GITHUB_TOKEN" --header "X-GitHub-Api-Version: 2022-11-28" "https://api.github.com/repos/MaterializeInc/materialize/issues/$line" -s | jq -r ".url" ; done

And ran sed commands to replace them. I'm not sure if we actually want this, but I prefer to have the actual link instead of one that will be redirected.

Follow-up to #29716

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Copy link
Contributor

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I prefer this as well.

@def- def- enabled auto-merge September 29, 2024 14:24
@def- def- force-pushed the pr-no-redirects branch 2 times, most recently from 6788c6c to 57f9dfa Compare September 29, 2024 19:16
Collected the issues via
  git grep "https://github.com/MaterializeInc/materialize/issues/" | sed -e "s/.*issues\/\([0-9]*\).*/\1/g" | sort -n | uniq
  git grep "materialize#" | sed -e "s/.*materialize#\([0-9]*\).*/\1/g" | sort -n | uniq > out

Then found the correct new urls via
  while read line; do curl --header "Authorization: Bearer $GITHUB_TOKEN" --header "X-GitHub-Api-Version: 2022-11-28" "https://api.github.com/repos/MaterializeInc/materialize/issues/$line" -s | jq -r ".url" ; done

And ran sed commands to replace them. I'm not sure if we actually want this, but I prefer to have the actual link instead of one that will be redirected.
@def- def- merged commit 97347ac into MaterializeInc:main Sep 29, 2024
78 checks passed
@def- def- deleted the pr-no-redirects branch September 29, 2024 23:47
@def- def- mentioned this pull request Sep 30, 2024
5 tasks
@chaas
Copy link
Contributor

chaas commented Sep 30, 2024

Thanks @def- ! Good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants