adapter,controller: add replica status history #29365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
force-pushed
the
mz_cluster_replica_status_history
branch
from
19414cb to
785592f
Compare
teskje
commented
Sep 9, 2024
benesch
reviewed
Sep 9, 2024
teskje
force-pushed
the
mz_cluster_replica_status_history
branch
from
785592f to
914c2fb
Compare
benesch
approved these changes
Sep 10, 2024
kay-kim
reviewed
Sep 11, 2024
This commit adds a new `mz_cluster_replica_status_history` source, which is a log-style version of `mz_cluster_replica_statuses`. This deprecates `mz_cluster_replica_statuses` but doesn't remove it yet, to give us time to migrate internal clients.
This commit adds support for truncation of the `ReplicaStatusHistory` collection during storage controller startup. In contrast to the other status histories, the replica status history is keyed by two columns (`replica_id`, `process_id`), so we need to modify the truncation code to work with multi-column keys. To this end, a `StatusHistoryDesc` type is introduced that allows the caller to configure the truncation behavior while being generic over the key type.
teskje
force-pushed
the
mz_cluster_replica_status_history
branch
from
914c2fb to
c96b861
Compare
|
TFTRs! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new builtin source
mz_cluster_replica_status_history, which contains the data already present inmz_cluster_replica_statusesbut as a (pseudo-) append-only collection, rather than a retained-metrics collection.The plan is to remove
mz_cluster_replica_statusesin favor of the new history source once all internal clients have been migrated.Motivation
Part of https://github.com/MaterializeInc/database-issues/issues/8403
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.