Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to AWS SDK v0.23/v0.53 #17390

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Conversation

benesch
Copy link
Member

@benesch benesch commented Jan 29, 2023

Blocked on awslabs/aws-sdk-rust#722. Downgraded to v0.23/v0.53 (which is still an upgrade from current main), as it doesn't have the aforementioned bug.

Motivation

  • Regular dependency bump PR.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.

  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.

  • If this PR will require changes to cloud orchestration, there is a
    companion cloud PR to account for those changes that is tagged with
    the release-blocker label (example).

  • This PR includes the following user-facing behavior changes:

    • n/a

@benesch benesch mentioned this pull request Jan 29, 2023
4 tasks
@benesch benesch changed the title deps: upgrade to AWS SDK v0.24/v0.54 deps: upgrade to AWS SDK v0.23/v0.53 Jan 29, 2023
@benesch benesch marked this pull request as ready for review January 29, 2023 22:07
@benesch benesch requested a review from a team as a code owner January 29, 2023 22:07
@benesch benesch requested a review from a team January 29, 2023 22:07
@benesch benesch requested a review from a team as a code owner January 29, 2023 22:07
@benesch benesch requested a review from a team January 29, 2023 22:07
@benesch benesch requested a review from a team as a code owner January 29, 2023 22:07
@benesch
Copy link
Member Author

benesch commented Jan 29, 2023

@alex-hunt-materialize the trick was to force path style addressing when the S3 endpoint is overridden (link), since local endpoints almost certainly don't support virtual host style addressing.

I expect this to go green, based on the last CI run, which only failed due to a minor formatting error. Marking this for automerge.

@benesch benesch enabled auto-merge (rebase) January 29, 2023 22:08
@benesch benesch merged commit 2271a77 into MaterializeInc:main Jan 29, 2023
@benesch benesch deleted the bump-aws-sdk branch January 29, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant