ore/cli: add env_prefix configuration option #12765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrioni
approved these changes
May 30, 2022
Add an `env_prefix` option to our CLI parsing module. This option will eventually come to clap itself (clap-rs/clap#3221), but for now we can roll it ourselves using clap's reflection API. This option will allow us to factor out common CLI options into their own structs while still having the environment variable prefixes determined by the root command.
guswynn
reviewed
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
env_prefixoption to our CLI parsing module. This option willeventually come to clap itself (clap-rs/clap#3221), but for now we can
roll it ourselves using clap's reflection API.
This option will allow us to factor out common CLI options into their
own structs while still having the environment variable prefixes
determined by the root command.
Motivation
Testing
Release notes
This PR includes the following user-facing behavior changes: