PasswordBox - Set vertical alignment of reveal button #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting to "Center" to align with PART_ClearButton. This threw me off, because the demo application overrides the style for PackIcon in Fields.xaml and explicitly sets VerticalAlignment=Center. The default however is Top, which is not correct. Instead of changing it directly on the PackIcon - which potentially is a bit too intrusive - I simply apply it directly on the PackIcon used in the reveal button.
Keboo
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue mentioned here.
Setting
VerticalAlignment=Centerto align withPART_ClearButton(default value).This threw me off initially, because the demo application overrides the style for
PackIconin Fields.xaml, and explicitly setsVerticalAlignment=Center. The default however isTop, which is not correct. Instead of changing it directly on thePackIconstyle - which potentially is a bit too intrusive - I simply apply it directly on thePackIconinstance used in the reveal button.Also, the
HorizontalAlignmentbeing removed was a leftover from earlier, and is no longer needed.