Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add users saved tracks #9

Merged
merged 6 commits into from
Sep 9, 2023
Merged

Conversation

shuaahvee
Copy link
Contributor

This PR adds a new stream that extracts a users saved tracks

@ReubenFrankel ReubenFrankel added the enhancement New feature or request label Jun 6, 2023
@ReubenFrankel
Copy link
Contributor

Hi @shuaahvee, thanks for submitting this. There are a few changes that need to be made before this can be merged:

  • Compatibility with relational database loaders (e.g. target-postgres)
  • MInor code syntax and formatting changes

Would you prefer I make suggestions to amend these in a review here? Otherwise, I am happy to do them myself. Up to you of course! 😄

@shuaahvee
Copy link
Contributor Author

I'm happy to make them! What changes do you have in mind?

tap_spotify/streams.py Outdated Show resolved Hide resolved
tap_spotify/streams.py Outdated Show resolved Hide resolved
tap_spotify/streams.py Outdated Show resolved Hide resolved
tap_spotify/streams.py Outdated Show resolved Hide resolved
@ReubenFrankel ReubenFrankel merged commit 9acd19a into Matatika:master Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants